Ksp opt in workaround #1833
Merged
Ksp opt in workaround #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evant
force-pushed
the
ksp-opt-in-workaround
branch
from
550e1e0
to
2bc6ad7
Compare
JakeWharton
force-pushed
the
ksp-opt-in-workaround
branch
from
2bc6ad7
to
d2aa641
Compare
JakeWharton
approved these changes
Feb 16, 2024
interop/ksp/src/main/kotlin/com/squareup/kotlinpoet/ksp/Annotations.kt
Outdated
Show resolved
Hide resolved
interop/ksp/src/main/kotlin/com/squareup/kotlinpoet/ksp/Annotations.kt
Outdated
Show resolved
Hide resolved
...t-processor/src/main/kotlin/com/squareup/kotlinpoet/ksp/test/processor/exampleAnnotations.kt
Outdated
Show resolved
Hide resolved
This works around an issue where OptIn annotations fail to compile using the explicit array syntax Fixes square#1831
evant
force-pushed
the
ksp-opt-in-workaround
branch
from
d2aa641
to
4c4eb5d
Compare
|
Can you add a change log entry for the fix? My 2024 resolution was to get better at adding change log entries along with PRs and I've been doing terribly so far. |
JakeWharton
reviewed
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdhas been updated if applicable.Stacked on #1832.Closes #1831.