Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-188] Add jlink script file support via set_script_file() #210

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

gtowers-dukosi
Copy link
Contributor

Add support for J-Link Script Files as detailed in #188

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2024

CLA assistant check
All committers have signed the CLA.

@hkpeprah hkpeprah self-requested a review August 26, 2024 14:11
Copy link
Contributor

@hkpeprah hkpeprah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, but otherwise seems good to go.

pylink/jlink.py Outdated Show resolved Hide resolved
pylink/jlink.py Outdated Show resolved Hide resolved
tests/unit/test_jlink.py Outdated Show resolved Hide resolved
gtowers-dukosi and others added 3 commits September 3, 2024 09:35
Co-authored-by: Ford Peprah <[email protected]>
Co-authored-by: Ford Peprah <[email protected]>
@gtowers-dukosi
Copy link
Contributor Author

Requested changes committed.

@hkpeprah
Copy link
Contributor

hkpeprah commented Sep 3, 2024

Sorry, was away for the long weekend. Taking a look now.

Copy link
Contributor

@hkpeprah hkpeprah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change. I'll try to get it out in a new minor release shortly.

@hkpeprah hkpeprah merged commit d29e6b0 into square:master Sep 3, 2024
5 checks passed
@gtowers-dukosi gtowers-dukosi deleted the jlinkscriptfile branch September 4, 2024 09:55
@hkpeprah
Copy link
Contributor

hkpeprah commented Sep 4, 2024

Release 1.3.0 should have a fix for this. Thanks again for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants