-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-188] Add jlink script file support via set_script_file() #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits, but otherwise seems good to go.
Co-authored-by: Ford Peprah <[email protected]>
Co-authored-by: Ford Peprah <[email protected]>
Co-authored-by: Ford Peprah <[email protected]>
Requested changes committed. |
Sorry, was away for the long weekend. Taking a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change. I'll try to get it out in a new minor release shortly.
Release 1.3.0 should have a fix for this. Thanks again for the patch! |
Add support for J-Link Script Files as detailed in #188