Bump reader sdk version to fetch for ios build and update xcodebuild to not code sign example app #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonjenniges
force-pushed
the
brandonjenniges/ci_fix
branch
4 times, most recently
from
b93438f
to
fd1c3be
Compare
brandonjenniges
force-pushed
the
brandonjenniges/ci_fix
branch
from
fd1c3be
to
3c0ec48
Compare
brandonjenniges
changed the title
brandonjenniges
force-pushed
the
brandonjenniges/ci_fix
branch
11 times, most recently
from
0f53dc0
to
b6830b9
Compare
brandonjenniges
force-pushed
the
brandonjenniges/ci_fix
branch
from
b6830b9
to
bffe01a
Compare
tobischw
reviewed
Sep 10, 2024
.github/workflows/main.yml
Outdated
| cd example | ||
| flutter pub get | ||
| cd ios | ||
| ruby <(curl https://connect.squareup.com/readersdk-installer) install --app-id ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} --repo-password ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} --version 1.6.1 > /dev/null | ||
| ruby <(curl https://connect.squareup.com/readersdk-installer) install --app-id ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} --repo-password ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} --version 1.7.4 > /dev/null |
There was a problem hiding this comment.
is it possible to define the version as a variable somewhere, similar to ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} ?
There was a problem hiding this comment.
I think you create an env yaml file and use it like this https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#using-the-env-context-to-access-environment-variable-values I'd much rather go that way because the app version isn't technically a secret
tobischw
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to main.yml