Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mutations #14

Closed
wants to merge 5 commits into from
Closed

Fix mutations #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42a645d
Fix mutate additional_headers
hellysmile Dec 10, 2019
93c81aa
Fix Configuration
hellysmile Dec 10, 2019
055781d
Fix mutation for http_client
hellysmile Dec 10, 2019
c637c97
Fix mutable __all__
hellysmile Dec 10, 2019
7d54cd7
Remove unsed json import
hellysmile Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions square/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
__all__ = [
__all__ = (
'api_helper',
'configuration',
'apis',
'http',
'exceptions',
'decorators',
'client',
]
)
4 changes: 2 additions & 2 deletions square/api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__all__ = [
__all__ = (
'base_api',
'mobile_authorization_api',
'o_auth_api',
Expand All @@ -20,4 +20,4 @@
'merchants_api',
'payments_api',
'refunds_api',
]
)
4 changes: 3 additions & 1 deletion square/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ def refunds(self):

def __init__(self, timeout=60, max_retries=3, backoff_factor=0,
environment='production', access_token='TODO: Replace',
additional_headers={}, config=None):
additional_headers=None, config=None):
if additional_headers is None:
additional_headers = {}
if config is None:
self.config = Configuration(timeout=timeout,
max_retries=max_retries,
Expand Down
5 changes: 4 additions & 1 deletion square/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ def additional_headers(self):

def __init__(self, timeout=60, max_retries=3, backoff_factor=0,
environment='production', access_token='TODO: Replace',
additional_headers={}):
additional_headers=None):
if additional_headers is None:
additional_headers = {}

# The value to use for connection timeout
self._timeout = timeout

Expand Down
4 changes: 2 additions & 2 deletions square/exceptions/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
__all__ = [
__all__ = (
'api_exception',
]
)
4 changes: 2 additions & 2 deletions square/http/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
__all__ = [
__all__ = (
'auth',
'http_method_enum',
'http_request',
'http_response',
'http_client',
'requests_client',
'http_call_back',
]
)
3 changes: 0 additions & 3 deletions square/http/api_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import json


class ApiResponse:

"""Http response received.
Expand Down
4 changes: 2 additions & 2 deletions square/http/auth/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
__all__ = [
__all__ = (
'o_auth_2',
]
)
80 changes: 60 additions & 20 deletions square/http/http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def convert_response(self, response, binary):
raise NotImplementedError("Please Implement this method")

def get(self, query_url,
headers={},
query_parameters={}):
headers=None,
query_parameters=None):
"""Create a simple GET HttpRequest object for the given parameters

Args:
Expand All @@ -71,6 +71,10 @@ def get(self, query_url,
HttpRequest: The generated HttpRequest for the given paremeters.

"""
if headers is None:
headers = {}
if query_parameters is None:
query_parameters = {}
return HttpRequest(HttpMethodEnum.GET,
query_url,
headers,
Expand All @@ -79,8 +83,8 @@ def get(self, query_url,
None)

def head(self, query_url,
headers={},
query_parameters={}):
headers=None,
query_parameters=None):
"""Create a simple HEAD HttpRequest object for the given parameters

Args:
Expand All @@ -93,6 +97,10 @@ def head(self, query_url,
HttpRequest: The generated HttpRequest for the given paremeters.

"""
if headers is None:
headers = {}
if query_parameters is None:
query_parameters = {}
return HttpRequest(HttpMethodEnum.HEAD,
query_url,
headers,
Expand All @@ -101,10 +109,10 @@ def head(self, query_url,
None)

def post(self, query_url,
headers={},
query_parameters={},
parameters={},
files={}):
headers=None,
query_parameters=None,
parameters=None,
files=None):
"""Create a simple POST HttpRequest object for the given parameters

Args:
Expand All @@ -120,6 +128,14 @@ def post(self, query_url,
HttpRequest: The generated HttpRequest for the given paremeters.

"""
if headers is None:
headers = {}
if query_parameters is None:
query_parameters = {}
if parameters is None:
parameters = {}
if files is None:
files = {}
return HttpRequest(HttpMethodEnum.POST,
query_url,
headers,
Expand All @@ -128,10 +144,10 @@ def post(self, query_url,
files)

def put(self, query_url,
headers={},
query_parameters={},
parameters={},
files={}):
headers=None,
query_parameters=None,
parameters=None,
files=None):
"""Create a simple PUT HttpRequest object for the given parameters

Args:
Expand All @@ -147,6 +163,14 @@ def put(self, query_url,
HttpRequest: The generated HttpRequest for the given paremeters.

"""
if headers is None:
headers = {}
if query_parameters is None:
query_parameters = {}
if parameters is None:
parameters = {}
if files is None:
files = {}
return HttpRequest(HttpMethodEnum.PUT,
query_url,
headers,
Expand All @@ -155,10 +179,10 @@ def put(self, query_url,
files)

def patch(self, query_url,
headers={},
query_parameters={},
parameters={},
files={}):
headers=None,
query_parameters=None,
parameters=None,
files=None):
"""Create a simple PATCH HttpRequest object for the given parameters

Args:
Expand All @@ -174,6 +198,14 @@ def patch(self, query_url,
HttpRequest: The generated HttpRequest for the given paremeters.

"""
if headers is None:
headers = {}
if query_parameters is None:
query_parameters = {}
if parameters is None:
parameters = {}
if files is None:
files = {}
return HttpRequest(HttpMethodEnum.PATCH,
query_url,
headers,
Expand All @@ -182,10 +214,10 @@ def patch(self, query_url,
files)

def delete(self, query_url,
headers={},
query_parameters={},
parameters={},
files={}):
headers=None,
query_parameters=None,
parameters=None,
files=None):
"""Create a simple DELETE HttpRequest object for the given parameters

Args:
Expand All @@ -201,6 +233,14 @@ def delete(self, query_url,
HttpRequest: The generated HttpRequest for the given paremeters.

"""
if headers is None:
headers = {}
if query_parameters is None:
query_parameters = {}
if parameters is None:
parameters = {}
if files is None:
files = {}
return HttpRequest(HttpMethodEnum.DELETE,
query_url,
headers,
Expand Down