Explicitly declare APPLICATION_EXTENSION_API_ONLY for CocoaPods
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lickel
commented
Jan 6, 2023
| test_spec.framework = 'XCTest' | ||
| test_spec.library = 'swiftos' | ||
| end | ||
| s.name = 'Workflow' |
There was a problem hiding this comment.
I changed all pod spec files to be consistent in formatting (4 spaces).
This can be hidden via adding ?w=1 to the diff URL (hide whitespace in the gear box)
lickel
commented
Jan 6, 2023
| @@ -19,7 +19,6 @@ Pod::Spec.new do |s| | |||
| s.source_files = 'WorkflowReactiveSwift/Sources/**/*.swift' | |||
|
|
|||
| s.dependency 'Workflow', "#{s.version}" | |||
| s.dependency 'ReactiveSwift', '~> 7.0.0' | |||
There was a problem hiding this comment.
This is redundant via s.dependency 'Workflow', "#{s.version}"
lickel
commented
Jan 6, 2023
|
|
||
| s.source_files = 'Workflow/Sources/*.swift' | ||
|
|
||
| s.dependency 'ReactiveSwift', '~> 7.1.1' |
There was a problem hiding this comment.
This release sets APPLICATION_EXTENSION_API_ONLY
jamieQ
approved these changes
Jan 6, 2023
| test_spec.dependency 'WorkflowTesting', "#{s.version}" | ||
| test_spec.dependency 'WorkflowReactiveSwift', "#{s.version}" | ||
| end | ||
| # https://github.com/ReactiveX/RxSwift/pull/2475 |
There was a problem hiding this comment.
do you want to wait for these changes to be available before merging/releasing this?
There was a problem hiding this comment.
Nah I have no idea if they want this, and if so, what the timeline would be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist