Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start sectioning off ReactiveSwift #177

Merged
merged 9 commits into from
Jan 10, 2023
Merged

Start sectioning off ReactiveSwift #177

merged 9 commits into from
Jan 10, 2023

Conversation

lickel
Copy link
Collaborator

@lickel lickel commented Jan 10, 2023 •
edited
Loading

Re-do of #173 within the repo (deleted my fork too soon)

I want to wean the core off of ReactiveSwift.

This PR does two things:

  • Update Package.swift
    • Reorganize the file
    • Expose the RxSwift flavors
    • Update ReactiveSwift to be consistent with the Podspec
  • Remove import ReactiveSwift for anything that didn't really need it

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@lickel lickel requested a review from a team as a code owner January 10, 2023 17:50
@lickel lickel merged commit d5faf6f into main Jan 10, 2023
@lickel lickel deleted the alickel/reactive-swift branch January 10, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamieQ jamieQ jamieQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lickel @jamieQ