Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: update swiftformat ifdef indent rule to no-indent #182

Merged
merged 2 commits into from
Jan 19, 2023
Merged

[chore]: update swiftformat ifdef indent rule to no-indent #182

merged 2 commits into from
Jan 19, 2023

Conversation

jamieQ
Copy link
Contributor

@jamieQ jamieQ commented Jan 19, 2023 •
edited
Loading

Issue

  • existing ifdef indentation rule doesn't match the style used in the rest of the Square codebase (and IMO makes the code more difficult to read)

Description

  • update swiftformat ifdef indent rule to no-indent
  • run rule on the repo

note: view the PR with the 'hide whitespace' option enabled (use settings or add the ?w=0 URL query param)

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@jamieQ jamieQ marked this pull request as ready for review January 19, 2023 03:57
@jamieQ jamieQ requested a review from a team as a code owner January 19, 2023 03:57
@jamieQ jamieQ merged commit 657f2ab into main Jan 19, 2023
@jamieQ jamieQ deleted the jquadri/ifdef-indent-rule branch January 19, 2023 14:06
jamieQ added a commit that referenced this pull request Feb 6, 2023
@jamieQ
Merge branch 'main' into jquadri/workflow-observers
7ac813a 
* main:
  [fix]: use weak reference to internal sinks when vending to clients (#189)
  [feat]: add primary associated types to more protocols (#188)
  [chore]: pre major version bump cleanup (#187)
  [chore]: bump minimum deployment & swift versions (#186)
  Abstract ViewEnvironment to shared framework (#185)
  Bump activesupport from 6.1.4.4 to 6.1.7.1 (#183)
  [feat]: add primary associated types to `Workflow` protocol (#181)
  [chore]: update swiftformat ifdef indent rule to no-indent (#182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjohnson12 mjohnson12 mjohnson12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamieQ @mjohnson12