[chore]: refactor some internal actions to use existential any #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
commented
Feb 7, 2023
|
|
||
| /// 'Opens' the existential `any WorkflowAction<WorkflowType>` value | ||
| /// allowing the underlying conformance to be applied to the Workflow's State | ||
| func openAndApply<A: WorkflowAction>( |
There was a problem hiding this comment.
it's not entirely clear to me why this is necessary, or exactly why it works, but if you try to invoke action.apply(...) on the any WorkflowAction variable, you get a compiler error. this makes some amount of sense b/c an any WorkflowAction isn't itself a WorkflowAction. i did skim this and this to see if there are other options, but this was the only thing i've been able to get working thus far.
jamieQ
commented
Feb 7, 2023
| @@ -272,7 +272,7 @@ extension WorkflowNode.SubtreeManager { | |||
|
|
|||
| fileprivate final class ReusableSink<Action: WorkflowAction>: AnyReusableSink where Action.WorkflowType == WorkflowType { | |||
| func handle(action: Action) { | |||
| let output = Output.update(AnyWorkflowAction(action), source: .external) | |||
| let output = Output.update(action, source: .external) | |||
There was a problem hiding this comment.
this change will help the observation API be more useful as we will be able to expose the underlying conformance and not an AnyWorkflow wrapper
mjohnson12
approved these changes
Feb 7, 2023
jamieQ
added a commit
that referenced
this pull request
Feb 7, 2023
…rvers * origin/main: [chore]: refactor some internal actions to use existential any (#190)
jamieQ
added a commit
that referenced
this pull request
Feb 25, 2023
…ow-workflow-conformance * origin/main: Expose AnyScreen.wrappedScreen for inspection (#193) Improve introspection for SignalProducerWorkflow actions (#192) [release]: bump version to 2.2.0 & remove separate concurrency version (#191) [feat]: add runtime observation API (#168) [chore]: refactor some internal actions to use existential any (#190) [fix]: use weak reference to internal sinks when vending to clients (#189) [feat]: add primary associated types to more protocols (#188) [chore]: pre major version bump cleanup (#187) [chore]: bump minimum deployment & swift versions (#186) Abstract ViewEnvironment to shared framework (#185)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
since we now have access to primary associated types, there are a couple places internally where it likely makes sense to leverage the language's 'existential' boxing facilities over our own. to start, we'll update a couple places that pass an
AnyWorkflowAction<T>that can now be replaced withany WorkflowAction<T>.additional comments inline.
Checklist