Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: add ViewEnvironmentUI and support automatic bridging in WorkflowUI #215

Merged
merged 4 commits into from
Jun 13, 2023
Merged

[feat]: add ViewEnvironmentUI and support automatic bridging in WorkflowUI #215

merged 4 commits into from
Jun 13, 2023

Conversation

n8chur
Copy link
Collaborator

@n8chur n8chur commented May 18, 2023 •
edited
Loading

Overview

This is the feature branch for the work that adds the ViewEnvironmentUI module and adds support to WorkflowUI for automatic bridging of the ViewEnvironment to/from node-based propagation to/from Screen's ViewEnvironment propagation system.

Checkout the individual PRs listed below for more information on these changes.

More information on these changes can be found in Proposal: WorkflowUI ViewEnvironment Propagation in UIKit.

Changes

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@n8chur n8chur changed the title [WIP] [feat]: add ViewEnvironmentUI and support automatic bridging in WorkflowUI [feat]: add ViewEnvironmentUI and support automatic bridging in WorkflowUI Jun 12, 2023
@n8chur n8chur marked this pull request as ready for review June 12, 2023 18:25
@n8chur n8chur requested review from a team as code owners June 12, 2023 18:25
watt
watt approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@watt watt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🌉 👍 (approval bridged from prior PRs)

@n8chur n8chur merged commit ccece24 into main Jun 13, 2023
@n8chur n8chur deleted the feature/viewenvironmentui branch June 13, 2023 17:24
jamieQ added a commit that referenced this pull request Jun 13, 2023
@jamieQ
Merge remote-tracking branch 'origin/main' into jquadri/workflowui-te…
9b898e4 
…lemetry

* origin/main:
  [feat]: add ViewEnvironmentUI and support automatic bridging in WorkflowUI (#215)
  [chore]: update codeowners (#223)
  Add missing keyword 'func' to Tutorial1.md (#219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watt watt watt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n8chur @watt