Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]: address some RenderTester limitations with optionals #245

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[fix]: address some RenderTester limitations with optionals #245

merged 1 commit into from
Sep 12, 2023

Conversation

jamieQ
Copy link
Contributor

@jamieQ jamieQ commented Sep 8, 2023 •
edited
Loading

Issue

due to generic type inference behavior, certain RenderTester utilities made it impossible (or at least convoluted) to test underlying Workflows that had outputs of Optional type.

Description

  • audited existing RenderTester extensions
  • added optional type parameters to methods that lacked a way to specify the expected generic types directly

Checklist

  • Unit Tests
    - [ ] UI Tests n/a
    - [ ] Snapshot Tests (iOS only) n/a
    - [ ] I have made corresponding changes to the documentation n/a

@jamieQ jamieQ marked this pull request as ready for review September 12, 2023 17:29
@jamieQ jamieQ requested a review from a team as a code owner September 12, 2023 17:29
@jamieQ jamieQ merged commit b4f86ae into main Sep 12, 2023
12 checks passed
@jamieQ jamieQ deleted the jquadri/testing-utils-fixes branch September 12, 2023 19:47
square-tomb added a commit that referenced this pull request Nov 4, 2023
@square-tomb
Merge branch 'main' of github.com:square/workflow-swift into tomb/swi…
b63c2d4 
…ftui-testbed

* 'main' of github.com:square/workflow-swift:
  Add WorkflowSwiftUIExperimental  (#252)
  Add convenience method for library definitions to reduce boilerplate (#251)
  [release]: bump to version 3.4.0 (#250)
  RxSwift 6.6 (#212)
  Expose 'screen' on WorkflowHostingController (#246)
  [fix]: address some RenderTester limitations with optionals (#245)
  Resolved Swift 5.9 compilation warning related to UnsafeRawPointer object conversion (#243)
  Bump activesupport from 6.1.7.3 to 6.1.7.6 (#242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@square-tomb square-tomb square-tomb approved these changes

@mjohnson12 mjohnson12 mjohnson12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamieQ @mjohnson12 @square-tomb