!chore: add watchOS support to ViewEnvironment and bump iOS to 15.0 #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
approved these changes
Feb 16, 2024
lickel
reviewed
Feb 16, 2024
watt
approved these changes
Feb 16, 2024
mjohnson12
approved these changes
Feb 16, 2024
Changed Tutorial deployment target to iOS 15 to fix build issue
|
I moved to using version number presets in the Package.swift and added tvOS/macCatalyst cc @mjohnson12 |
mjohnson12
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds watchOS 8 support to
ViewEnvironmentand bumps iOS minimum deployment target to 15.0.We noticed the need to add watchOS support when we found that Market publishing was failing.
Why
ViewEnvironmentis imported inMarketSwiftUIwhich requires watchOS support, and all of our upstream dependencies at square are now on the iOS 15 minimum deployment target so it seems like it might be worth bumping just for future convenience when contributing to this workflow-swift.Checklist