Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: add comment describing SwiftUIScreen's background color override #278

Merged
merged 1 commit into from
Mar 29, 2024
Merged

[chore]: add comment describing SwiftUIScreen's background color override #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions WorkflowSwiftUIExperimental/Sources/SwiftUIScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ private final class ModeledHostingController<Model, Content: View>: UIHostingCon
override func viewDidLoad() {
super.viewDidLoad()

// `UIHostingController`'s provides a system background color by default. In order to
// support `SwiftUIScreen`s being composed in contexts where it is composed within another
// view controller where a transparent background is more desirable, we set the background
// to clear to allow this kind of flexibility.
view.backgroundColor = .clear

setNeedsLayoutBeforeFirstLayoutIfNeeded()
Expand Down
Loading