Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 5428: Warn if pkg-config is not found #1902

Closed
wants to merge 2 commits into from
Closed

Bug 5428: Warn if pkg-config is not found #1902

wants to merge 2 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Sep 17, 2024 •
edited by rousskov
Loading

Squid builds without pkg-config, but results are likely to surprise
administrators because many optional features will not be
default-enabled despite properly installed libraries.

@kinkie
Copy link
Contributor Author

kinkie commented Sep 17, 2024

Sample output from configure on a system with no pkg-config:

[...]
checking for rm... /opt/homebrew/opt/coreutils/libexec/gnubin/rm
checking for pkg-config... no
configure: WARNING: pkg-config not found. Squid might still build but miss some features, and 'make check' might fail
checking for perl... /usr/bin/perl
[...]

@kinkie kinkie mentioned this pull request Sep 17, 2024
Closed
@rousskov rousskov self-requested a review September 18, 2024 02:30
@kinkie
Copy link
Contributor Author

kinkie commented Sep 18, 2024

abandoning, as discussion is happening in #1901

@kinkie kinkie closed this Sep 18, 2024
@squid-anubis squid-anubis added the M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels label Sep 18, 2024
@kinkie kinkie reopened this Sep 18, 2024
@kinkie
Copy link
Contributor Author

kinkie commented Sep 18, 2024

Reopening, #1901 has been abandoned.

@squid-anubis squid-anubis removed the M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels label Sep 18, 2024
@rousskov
fixup: Polish warning text
8b19e64 
Do not warn about "make check" failing twice.
We already have code dedicated to that warning.

Do not try to predict whether Squid will build
(the admin will observe that outcome anyway).
Focus on the missing features instead.
rousskov
rousskov approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this warning. I polished PR description and the warning text a little. Please feel free to undo my changes or polish further, of course. The only bit I kind of insist on is that we do not have two warnings about expected "make check" failures; I removed the one that this PR was adding.

@rousskov rousskov added the S-waiting-for-author author action is expected (and usually required) label Sep 18, 2024
@kinkie
Copy link
Contributor Author

kinkie commented Sep 18, 2024

I'll reword it a little to highlight the unpredictability of the results

@rousskov
Copy link
Contributor

FWIW, I disagree that these results are unpredictable. Surprising to many admins? Yes! Can they be predicted reliably given enough information about the build environment? Yes, they can be.

squid-anubis pushed a commit that referenced this pull request Sep 19, 2024
@kinkie @squid-anubis
Bug 5428: Warn if pkg-config is not found (#1902)
721c1cf 
Squid builds without pkg-config, but results are likely to surprise
administrators because many optional features will not be
default-enabled despite properly installed libraries.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Sep 19, 2024
squid-anubis pushed a commit that referenced this pull request Sep 20, 2024
@kinkie @squid-anubis
Bug 5428: Warn if pkg-config is not found (#1902)
5b8668e 
Squid builds without pkg-config, but results are likely to surprise
administrators because many optional features will not be
default-enabled despite properly installed libraries.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Sep 20, 2024
squid-anubis pushed a commit that referenced this pull request Sep 20, 2024
@kinkie @squid-anubis
Bug 5428: Warn if pkg-config is not found (#1902)
0bbb86f 
Squid builds without pkg-config, but results are likely to surprise
administrators because many optional features will not be
default-enabled despite properly installed libraries.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Sep 20, 2024
@squid-anubis squid-anubis removed the M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Sep 22, 2024
squid-anubis pushed a commit that referenced this pull request Sep 23, 2024
@kinkie @squid-anubis
Bug 5428: Warn if pkg-config is not found (#1902)
ea10f7d 
Squid builds without pkg-config, but results are likely to surprise
administrators because many optional features will not be
default-enabled despite properly installed libraries.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Sep 23, 2024
@kinkie kinkie added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed S-waiting-for-author author action is expected (and usually required) M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Sep 23, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Sep 23, 2024
kinkie added a commit to kinkie/squid that referenced this pull request Oct 12, 2024
@kinkie
Bug 5428: Warn if pkg-config is not found (squid-cache#1902)
d768f13 
Squid builds without pkg-config, but results are likely to surprise
administrators because many optional features will not be
default-enabled despite properly installed libraries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yadij yadij yadij approved these changes

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinkie @rousskov @yadij @squid-anubis