Maintenance: Fix EventScheduler::timeRemaining() comment #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousskov
commented
Oct 13, 2024
| @@ -204,7 +204,7 @@ EventScheduler::timeRemaining() const | |||
| if (tasks->when <= current_dtime) // we are on time or late | |||
| return 0; // fire the event ASAP | |||
|
|
|||
| const double diff = tasks->when - current_dtime; // microseconds | |||
| const double diff = tasks->when - current_dtime; // seconds | |||
There was a problem hiding this comment.
I did not change the type of diff variable to auto because this code secretly relies on diff type being an arithmetic type. For example, when using std::chrono::duration for diff, 1000*diff expression below will compile but will not convert seconds to milliseconds as intended. Event::when type, this whole method (including its return type), and method callers should be reworked using std::chrono, but this is a minimal PR fixing (my 2013 commit aa14d75) bug that wasted 30 minutes of my time.
Said that, if you insist on auto upgrade, just apply this suggestion:
Suggested change
| const double diff = tasks->when - current_dtime; // seconds | |
| const auto diff = tasks->when - current_dtime; // seconds |
rousskov
added
M-cleared-for-merge
rousskov
changed the title
kinkie
approved these changes
Oct 14, 2024
squid-anubis
pushed a commit
that referenced
this pull request
Oct 15, 2024
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
rousskov
removed
the
S-could-use-an-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.