-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown 3.2 and Pymdown Extensions 6.3 Released with code block changes #1450
Comments
So if I understand correctly, this applies to CodeHilite and Highlight, right? This would mean we could remove a significant amount of CSS, as I always tried to also make the non-Pygments case work. We could then just use I guess Pymdown adds an explicit dependency for |
requirements.txt in this repo contains an explicit requirement |
@madmpro that is correct. However, I do not yet understand how this causes you trouble, see #1331 (comment) |
I added requirement |
At https://github.com/pipxproject/pipx, we just had our doc build fail with a version conflict because mkdocs-material requires markdown<3.2 (which is why I'm here). I'll try @madmpro's workaround to see if we can get our builds going again. |
Hi! I believe I am in the same situation as @itsayellow. I thought it could be useful to highlight the issue with my dependency graph:
This makes dependency resolution fail (in Pipenv at least). Let me know if this should be dealt with in a different issue, or if I can help in any way! And thanks a lot for mkdocs-material, by the way, it's truly great! |
Place the markdown required version in the head of requirements file, or at least, before pymdown-extensions requirement. |
Let me take a look in venv environment. Depending on how dependencies are installed, there may be a hiccup. |
Okay, I tested this out in a virtual environment. If you install just So either just install
|
This was intended to avoid complaints, but in the end, it seems crisis could not be averted either way 😞 . |
If it is easier to relax this and just have peoples code padding off, we could always do that as well. At least in pymdown-extensions, there is a legacy option to revert to the old code block form. But not with CodeHilite 🤷♂ . The alternative is to fix the code padding issue and then relax the requirement. |
The only place this will not apply is when using table form of code blocks with numbers in the gutter. The content will be |
In case you missed it, as per mkdocs/mkdocs#1970, the next release of MkDocs will require Markdown 3.2. Just thought you guys would want to know that so you can plan for it. |
See squidfunk/mkdocs-material#1450 for more background
See squidfunk/mkdocs-material#1450 for more background
I checked that...
Description
Markdown 3.2 and Pymdown Extensions 6.3 were just released. This forces Pygments code blocks to always be wrapped in code blocks:
<div><pre><code></code></pre></div>
. This is different that the previous<div><pre></pre></div>
convention.Pymdown already accounts for this in its own documents, and all that was needed is:
If you don't get to it first, I'll try to come up with a pull, but wanted to at least create an issue now.
The text was updated successfully, but these errors were encountered: