Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if the native prototype method exists by evaluating it. #195

Merged
merged 4 commits into from
Jun 20, 2020

Conversation

vinothbabu
Copy link

The change is for the below error thrown from typescript "This condition will always return true since the function is always defined. Did you mean to call it instead? "

@nebrelbug
Copy link
Collaborator

I think now you'll have to ESLint-disable no-extra-boolean-cast, it's something like (on the same line as the condition in the if statement)

if (...) { // eslint-disable-line no-extra-boolean-cast

@vinothbabu
Copy link
Author

The build passed, but why is the Codacy not able to pull my request for quality review?

@vinothbabu
Copy link
Author

@nebrelbug Do you see any issue with the pull request?

@nebrelbug
Copy link
Collaborator

@vinothbabu this looks great to me 🎉! I think I haven't set up Codacy to work correctly with contributor PR's.

I'll merge this today or tomorrow, and leave this open so I remember :)

@nebrelbug nebrelbug merged commit ffd9c9e into squirrellyjs:master Jun 20, 2020
@nebrelbug
Copy link
Collaborator

@vinothbabu so sorry I took so long to merge this! I just released version 8.0.2, which incorporates this PR.

@vinothbabu
Copy link
Author

@nebrelbug That's absolutely fine, thanks. I will be happy to help more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants