Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file handler renderFile function #201

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Update file handler renderFile function #201

merged 1 commit into from
Sep 5, 2020

Conversation

futurelucas4502
Copy link
Contributor

Updated the file_handler renderFile function to allow for an undefined data parameter fixing a crash

@nebrelbug
Copy link
Collaborator

@futurelucas4502 this looks fantastic! I'll merge right now.

By the way, are you ok if I add you to the README as a contributor?

@nebrelbug nebrelbug merged commit 31d0268 into squirrellyjs:master Sep 5, 2020
@futurelucas4502
Copy link
Contributor Author

@nebrelbug yeah that'd be awesome! 😄

@nebrelbug
Copy link
Collaborator

@all-contributors please add @futurelucas4502 for bugs and code.

@allcontributors
Copy link
Contributor

@nebrelbug

I've put up a pull request to add @futurelucas4502! 🎉

@nebrelbug
Copy link
Collaborator

@futurelucas4502 just added you to the README 🎉

Thank you! Hope you're able to contribute in the future 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error can occur if no data is passed to renderFile() as no check is done to see if data is defined
2 participants