MultipleStatementAlignment: do not break on comments within arrays. #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi-line arrays interspersed with comments were treated differently than multi-line arrays without comments. This aligns the behaviour of both to be the same. Includes unit tests.
jrfnl
force-pushed
the
feature/generic-multistatementalignment-phpcs-annotations
branch
from
12ab2d1
to
8386ad3
Compare
|
Rebased for merge conflict with commit f65239d which basically does the same as this PR does for arrays, but then for closures and anonymous classes. |
|
@gsherwood I believe this one should go in the |
|
Thanks |
jrfnl
deleted the
feature/generic-multistatementalignment-phpcs-annotations
branch
This was referenced Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-line arrays interspersed with comments were treated differently than multi-line arrays without comments.
This aligns the behaviour of both to be the same.
Includes unit tests.