Use Exceptions consistently #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can see, Exceptions thrown by sniffs/utility methods when, for instance, a wrong token is passed, should be `RuntimeException`s, while Exceptions thrown by the `Tokenizer` classes should be `TokenizerException`s. In a number of places this was applied inconsistently. This has now been fixed. Aside from that, for quite a number of methods, the `Exception` being thrown has now been documented.
12 tasks
|
Thanks a lot for fixing these up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on bd961bb, a further review of the Exceptions being thrown showed some inconsistencies.
As far as I can see, Exceptions thrown by sniffs/utility methods when, for instance, a wrong token is passed, should be
RuntimeExceptions, while Exceptions thrown by theTokenizerclasses should beTokenizerExceptions.In a number of places this was applied inconsistently. This has now been fixed.
Aside from that, for quite a number of methods, the
Exceptionbeing thrown has now been documented.