Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 | File::getClassProperties(): add support for readonly classes #3686

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Oct 6, 2022

PHP 8.2 introduces readonly classes. The readonly keyword can be combined with the abstract or final keyword. See: https://3v4l.org/VIXgD

Includes adding a full set of tests for the File::getClassProperties() method, which was so far untested.

Ref:

PHP 8.2 introduces `readonly` classes. The `readonly` keyword can be combined with the `abstract` or `final` keyword. See: https://3v4l.org/VIXgD

Includes adding a full set of tests for the `File::getClassProperties()` method, which was so far untested.

Ref:
* https://wiki.php.net/rfc/readonly_classes
@jrfnl
Copy link
Contributor Author

jrfnl commented Oct 6, 2022

FYI: I have follow-up commits ready for 11 sniffs to take readonly classes into account.

@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 8, 2023

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants