fix apache#3738 DuckDB: ALTER COLUMN statement not working

sramazzina · Mar 19, 2024 · e8eead3 · e8eead3
1 parent bdc3d64
commit e8eead3
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/...ns/databases/duckdb/src/main/java/org/apache/hop/databases/duckdb/DuckDBDatabaseMeta.java b/...ns/databases/duckdb/src/main/java/org/apache/hop/databases/duckdb/DuckDBDatabaseMeta.java
@@ -38,6 +38,11 @@ public class DuckDBDatabaseMeta extends BaseDatabaseMeta implements IDatabase {
 
     private static final Class<?> PKG = DuckDBDatabaseMeta.class; // For Translator
 
+    @Override
+    public String getCreateTableStatement() {
+        return super.getCreateTableStatement();
+    }
+
     @Override
     public String getFieldDefinition(IValueMeta v, String tk, String pk, boolean useAutoIncrement, boolean addFieldName, boolean addCr) {
         // https://duckdb.org/docs/sql/data_types/overview.html
@@ -47,9 +52,11 @@ public String getFieldDefinition(IValueMeta v, String tk, String pk, boolean use
         int length = v.getLength();
         int precision = v.getPrecision();
 
-        if (addFieldName) {
-            retval += fieldname + " ";
-        }
+      if (addFieldName) {
+        retval += fieldname + " ";
+      } else {
+        retval += fieldname + " TYPE ";
+      }
 
         int type = v.getType();
         switch (type) {
@@ -142,7 +149,7 @@ public boolean isDuckDbVariant() {
 
     @Override
     public String getURL(String hostname, String port, String databaseName) throws HopDatabaseException {
-        return "jdbc:duckdb:" + databaseName;
+        return "jdbc:duckdb:" + (databaseName.equals("memory") ? "" : databaseName);
     }
 
     @Override
@@ -158,7 +165,7 @@ public String getModifyColumnStatement(String tableName, IValueMeta v, String tk
         return "ALTER TABLE "
                 + tableName
                 + " ALTER COLUMN "
-                + getFieldDefinition(v, tk, pk, useAutoIncrement,true, false);
+                + getFieldDefinition(v, tk, pk, useAutoIncrement,false, false);
     }
 
     @Override