Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #211

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Update README.md #211

merged 2 commits into from
Apr 4, 2019

Conversation

suhaibmujahid
Copy link
Contributor

go get gopkg.in/src-d/enry.v1/...: unrecognized import path "gopkg.in/src-d/enry.v1/..." (parse https://gopkg.in/src-d/enry.v1/...?go-get=1: no go-import meta tags ())

Signed-off-by: Suhaib Mujahid <[email protected]>
@creachadair creachadair requested a review from bzz April 2, 2019 04:27
README.md Outdated Show resolved Hide resolved
@bzz
Copy link
Contributor

bzz commented Apr 2, 2019

Thank you for the patch @suhaibmujahid!
What do you think about changing it as in #211 (comment) ?

@suhaibmujahid
Copy link
Contributor Author

Thank you @bzz for consideration.

I tried it but it didn't work:

go get gopkg.in/src-d/enry.v1/cmd/enry: invalid module path "gopkg.in/src-d/enry.v1/cmd/enry"

I'm trying to use enry as a dependency in my application and the modification that I proposed worked for me.

Have a good day :)

@creachadair
Copy link
Contributor

creachadair commented Apr 3, 2019

I tried it but it didn't work:

go get gopkg.in/src-d/enry.v1/cmd/enry: invalid module path "gopkg.in/src-d/enry.v1/cmd/enry"

I'm trying to use enry as a dependency in my application and the modification that I proposed worked for me.

Hmm, that error surprises me. What version of Go are you currently building with (go version)?

@suhaibmujahid
Copy link
Contributor Author

I'm using go1.11.5 darwin/amd64with versioned modules.

@creachadair
Copy link
Contributor

creachadair commented Apr 3, 2019

Thanks. I am unfortunately having some trouble reproducing this issue right now. Here's what I tried—if you run this locally does it work?

# Acquire Go 1.11.5
go get golang.org/dl/go1.11.5
go1.11.5 download
#
go1.11.5 clean -modcache

# First, let's try it without modules.
rm $GOPATH/bin/enry
env -u GO111MODULE go1.11.5 get gopkg.in/src-d/enry.v1/cmd/enry
# works OK
enry -version
# undefined (OK)

# Now let's try it with modules enabled.
rm $GOPATH/bin/enry
mkdir testing ; cd testing ; go mod init testing
env GO111MODULE=on go1.11.5 get gopkg.in/src-d/enry.v1/cmd/enry
enry -version
# undefined (OK)

@suhaibmujahid
Copy link
Contributor Author

After running clean -modcache it worked.

go get gopkg.in/src-d/enry.v1/cmd/enry
# go: downloading gopkg.in/src-d/enry.v1 v1.7.2
# go: downloading gopkg.in/toqueteos/substring.v1 v1.0.2
# go: downloading github.com/toqueteos/trie v1.0.0
enry -version
# undefined

Thank you.

Co-Authored-By: SuhaibMujahid <[email protected]>
Signed-off-by: Suhaib Mujahid <[email protected]>
@creachadair
Copy link
Contributor

Thanks. I suspect you might have had a broken module hash somewhere from an earlier 1.11 build (cf. golang/go#27093).

@bzz bzz merged commit 33cc83f into src-d:master Apr 4, 2019
@suhaibmujahid suhaibmujahid deleted the patch-1 branch April 4, 2019 13:58
@bzz bzz added this to the v1.7.3 milestone Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants