This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: TreeWalker performance improvement, bufio pool for objects #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saracen
force-pushed
the
tree-walk-optimization
branch
from
ae112cc
to
2efbdaa
Compare
|
Are you reading my mind? Seriously, I just hit this performance bottleneck on my code for generating bloom filters :) |
mcuadros
reviewed
Apr 22, 2019
plumbing/object/tree.go
Outdated
| w.base = path.Join(w.base, entry.Name) | ||
| if obj != nil { | ||
| w.stack = append(w.stack, &treeEntryIter{obj, 0}) | ||
| if len(w.base) > 0 { |
There was a problem hiding this comment.
Can you move this code to a function instead of duplicate it?
saracen
force-pushed
the
tree-walk-optimization
branch
from
2efbdaa
to
936f65d
Compare
Removes path.Clean and path.Join, as they're expensive in comparison to basic string manipulation that can be used here. Adds bufio.Buffer pool to be used by tag, tree and commit object decoding. Signed-off-by: Arran Walker <[email protected]>
jfontan
approved these changes
Apr 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
path.Cleanandpath.Join, as they're expensive in comparison to basic string manipulation that can be used here.Added bufio.Buffer pool to be used by tag, tree and commit objects.