This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
Custom cache #947
Closed
Custom cache #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2018 20:15
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
erizocosmico
approved these changes
Sep 6, 2018
ajnavarro
approved these changes
Sep 6, 2018
jfontan
approved these changes
Sep 6, 2018
smola
approved these changes
Sep 6, 2018
|
The options struct is a container of flags, is not designed to container pointer or state. |
|
@kuba-- if you need to configure the cache, just send put in the constructor as another arg. |
|
@mcuadros Is not just configure the cache, we want to have control about the instance itself, to be able to share it between several repositories or change the implementation to fit our use case, per example. Should we send it as another constructor param? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to let apps. adjust cache size (or pass own implementation) we need to expose it somehow.
Recently we added Options to ObjectStorage, so instead of extending ObjectStorage structure and implement new constructors WithCache, I've moved cache under Options structure.
It's related to src-d/gitbase#440