added support for $EDITOR not being an executable #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing an executable
srid
reviewed
Jun 11, 2020
neuron/src/app/Neuron/CLI/New.hs
Outdated
| -- Show it first in case the editor launch fails | ||
| showAction path | ||
| executeFile editorExe True [path] Nothing | ||
| executeFile "bash" True ["-c", editor ++ ' ' : path ] Nothing |
There was a problem hiding this comment.
Wouldn't this break if path had whitespace in it?
There was a problem hiding this comment.
does path not create escape characters? How was it working before?
srid
reviewed
Jun 12, 2020
neuron/src/app/Neuron/CLI/New.hs
Outdated
| @@ -45,11 +44,11 @@ newZettelFile NewCommand {..} = do | |||
| case mzid of | |||
| Left e -> die $ show e | |||
| Right zid -> do | |||
| path <- zettelPath zid | |||
| (notesDir, filename) <- zettelPath zid | |||
There was a problem hiding this comment.
Let's get rid of the zettelPath function, and inline its body here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's kind of a hack, but in order to well support whatever they have as their $EDITOR you'll need to interpret shell faithfully, so it has to be a bit hacky. I wanted to use
sh, but sh doesn't have the-coption (I don't think it's posix). I suppose this could be improved by checking the shell environment variable and acting accordingly, but supporting shells that don't have the "-c" option seems impossible. I figured trying to support all shells was futile so I just passed it to bash because that covers 99.9% of cases. (if your $EDITOR is not bash compliant I'm curious what black magic you are doing)