Fix a few preexisting issues noticed during review #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filtering categories is opt-in, thus the default of True is wrong. There is only one active usage of `make_lock_files` which sets `filter_categories` explicitly, so changing this value shouldn't break anything.
These lists are not optional, so `or []` doesn't seems to accomplish anything.
This is obsolete since we no longer use aggregate_lock_specs to aggregate specs from separate platforms.
We shouldn't compute `platforms` again in a different way. Instead we pass the value we already computed, and then we perform a consistency check whenever `len(lock_specs) > 0`.
|
See the commit annotations for explanations. |
|
Tests: conda#384 |
srilman
pushed a commit
that referenced
this pull request
Nov 24, 2023
…file Add test for PipRepository aggregation
srilman
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Refactor manylinux tag logic * Run doctests * Remove unused logger * Clarify that legacy manylinux tags aren't glibc versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing your PR I got confused by some strange preexisting code, which I clean up here.