Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont let deepequal freak out on empty vs nil slice when disableExpose is true #165

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

carlmontanari
Copy link
Contributor

resolves #164 (hopefully :P -- but I tested it and could repro and this fixes it!)

@carlmontanari carlmontanari merged commit bf8e8ed into main Aug 9, 2024
4 checks passed
@carlmontanari carlmontanari deleted the fix/disable-expose-reconcile-issue branch August 9, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting disableExpose to true causes reconcile errors and continuous k8s resource creation.
1 participant