[Breaking] Allow multiple git commands #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srt32
reviewed
Mar 4, 2019
| @@ -8,7 +8,7 @@ LABEL "com.github.actions.color"="yellow" | |||
| LABEL "repository"="http://github.com/srt32/git-actions" | |||
| LABEL "homepage"="http://github.com/srt32/git-actions" | |||
|
|
|||
| RUN apk add --no-cache git bash git-subtree | |||
| RUN apk add --no-cache git git-subtree | |||
There was a problem hiding this comment.
@ArnaudRinquin is there not a need for bash here?
There was a problem hiding this comment.
Na, since the entrypoint file changes the shebang to #!/bin/sh
srt32
reviewed
Mar 4, 2019
|
|
||
| action "git command" { | ||
| uses = "srt32/[email protected]" | ||
| args = ["status", "show"] |
srt32
reviewed
Mar 4, 2019
| echo "Failure running 'git $cmd', exited with $exit_code" | ||
| exit $exit_code | ||
| fi | ||
| done |
There was a problem hiding this comment.
Would you mind adding a new line here?
|
@ArnaudRinquin I fixed up the merge conflicts and left a few questions. I do agree this change would be great even though it's breaking. Once we get this change merged, I can release a new update to the action. 🙇 |
Lincoln101-ai
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple git commands to be run. It's based on
actions/bin/sh.It also prefixes the commands with
gitso you don't have to, as inspired by the officialactions/docker