Fix audio_get_status result

[kira-bruneau]

audio_get_status returns an audio status, and doesn't propagate the transmit result:

• https://github.com/Pulse-Eight/libcec/blob/libcec-6.0.2/src/libcec/LibCECC.cpp#L539-L545
• https://github.com/Pulse-Eight/libcec/blob/libcec-6.0.2/src/libcec/LibCEC.cpp#L572-L575
• https://github.com/Pulse-Eight/libcec/blob/libcec-6.0.2/src/libcec/CECClient.cpp#L824-L829
• https://github.com/Pulse-Eight/libcec/blob/libcec-6.0.2/src/libcec/devices/CECAudioSystem.cpp#L153-L171

Also the status doesn't neatly fit into a Rust enum, so I removed the existing enum and added a wrapper struct.

Page 260 of High-Definition Multimedia Interface Specification 1.3a

[ssalonen]

Thanks!

Hmm the enum*.rs is autogenerated by https://github.com/ssalonen/libcec-sys/blob/master/scripts/run-bindgen/bindgen.sh

So somethings needs to be done there... need to have a bit closer look to comment something sensible

can you add simple tests to the conversion similar to other such functions in this lib?

[kira-bruneau]

Oh ok! I'll just add them back. I mainly just removed them because the new struct made those enums unnecessary.

I'll also keep using the constants from libcec_sys for the struct, because CEC_AUDIO_VOLUME_STATUS_UNKNOWN conflicts with CEC_AUDIO_VOLUME_STATUS_MASK. It'd be a bit confusing to useCecAudioStatus::MuteStatusMask to check when the status is unknown.

[ssalonen]

Yes I think it's ok to keep all enums as-is and having this usability-layer separately like you have done here with new struct

[kira-bruneau]

I refactored my changes a bit so this new struct can be used with https://github.com/ssalonen/cec-alsa-sync.

• Replaced KnownCecAudioStatus::new with a method that takes a separate volume & is_muted parameter.
• Added a TryFrom<u8> implementation to handle converting from a raw status (also adds a variant for the reserved value error case)

[ssalonen]

Thank you! Added few small colments