Add adapter auto detection for unspecified port #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kira-bruneau
commented
Sep 12, 2024
| } | ||
|
|
||
| let port = unsafe { adapters.assume_init() }[0].strComName; | ||
| if unsafe { libcec_open(connection.1, port.as_ptr(), open_timeout) == 0 } { |
There was a problem hiding this comment.
I decided to call libcec_open in both branches of this match block to the avoid the overhead of converting strCommName to a CString.
|
Oh sweet, good work! |
ssalonen
reviewed
Sep 19, 2024
kira-bruneau
force-pushed
the
autodetect-adapter
branch
from
9df5dd3
to
4853e37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, now if you leave off the port in the configuration, the first adapter will be selected automatically. Like in cec-client.
Based off the work @opeik started for #45 and closes #45.