Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more typos #16

Closed
wants to merge 2 commits into from
Closed

more typos #16

wants to merge 2 commits into from

Conversation

cmoid
Copy link
Contributor

@cmoid cmoid commented Aug 2, 2023

sorry I should bundle these and push them en masse. I'm implementing this spec as an elixir exercise and reading it closely.

As an aside, the reference python implementation has some missing links and the distribution leaves out some test codes also mentioned.

@staltz
Copy link
Member

staltz commented Aug 2, 2023

I'm not sure I understand the addition of the BYTES_VAL and whether it's a breaking change (if someone were to follow the spec strictly and blindly), so I'll defer to @tschudin .

@cmoid
Copy link
Contributor Author

cmoid commented Aug 2, 2023

oops, I misread that. I had done pattern recognition on the two and thought it missing :)

I'll resubmit the other typo when I push up my implementation, in case I find more.

@cmoid cmoid closed this Aug 2, 2023
@tschudin
Copy link
Contributor

tschudin commented Aug 2, 2023

@cmoid : Please note that I do not see or get notified about some PRs or discussions you had, good that @staltz referenced my handle in the comment. Great that an independent implementation is coming, and thanks for the typo fixes!

BTW: for the ESP32 side of tinySSB I now also have a C++ implementation, if that is helpful. See https://github.com/ssbc/tinySSB/blob/main/esp32/loramesh-TBeam/bipf.cpp

@gpicron
Copy link

gpicron commented Aug 11, 2023

@tschudin

  • the link to the github repo of the python reference impl is broken at https://pypi.org/project/bipf/
  • the nim implementation can also be used on esp32 (I'm making some tests together with https://github.com/elcritch/nesper
  • I proposed similar change for the ints for the original BIPF spec Large Int problem bipf-spec#1 . The main difference was that I proposed a zigzag encoding of int before keeping only the most significant bytes. Actually this is because I made some stats on existing content of SSB and there is quite a lot of "-1" encoded (negative votes) and simply keeping the most significant bytes in that cases mean 8 bytes...
  • A change on the original BIPF was recently merged Convert NULLBOOL type to ATOM type bipf-spec#3. It converts the BOOLNULL field to ATOM, allowing applications to use value 3, 4, 5 to encode application specific "value" known by it. The primary use was to compress further the on-disk storage of entries in BIPF using key dictionaries and value dictionaries in the context of SSB-Archive (which I abandonned as it does not make sense anymore with pppp). But now I'm using it in the com between some ESP32 using session hash table like in Erlang OTP network. I think you may find some use of it for tinySSB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants