Filter duplicate interfaces from incoming #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianbundy
force-pushed
the
filter-incoming
branch
from
0366709
to
5965379
Compare
|
If this is an important hotfix, feel free to merge, I reviewed and I think it's good to go. Note for the future, though, see my comments inline. |
staltz
reviewed
Jan 15, 2020
| // legacy configuration didn't have a scopes concept, | ||
| // so interpret that as every scope at once. | ||
| // I think there is probably a better way to do this, | ||
| // but am fairly sure this will probably work. |
There was a problem hiding this comment.
Code style changes are best done in their own commit, it makes it significantly easier to review (I can browse the commits and focus my attention only on the non-style commits), and makes the git blame process easier too.
staltz
reviewed
Jan 15, 2020
| acc.push(cur) | ||
| } | ||
|
|
||
| return acc |
There was a problem hiding this comment.
To simplify this code, I would probably refactor this arrow function to be a named function uniqueAddresses that's defined as a top-level function and then I'd use it as reduce(uniqueAddresses). I would do the same for the other parts of this chain of array methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ssbc/patchwork#1222