add ability to interpret json schema format #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me, date and time
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
dokempf
requested changes
Nov 2, 2023
| if hasattr(ipywidgets, "DatePicker"): | ||
| available_fmt.append("date") | ||
| if hasattr(ipywidgets, "TimePicker"): | ||
| available_fmt.append("time") |
There was a problem hiding this comment.
What is the rationale behind these checks? Have the relevant widgets been introduced very recently into ipywidgets?
There was a problem hiding this comment.
Yes, they were added in 8. The test suite also runs agains 7, so in order to pass the tests I had to add these checks.
There was a problem hiding this comment.
Ah yes, I have slightly rewritten this in #87, as I would like to avoid doing to much hasattr stuff.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for our use case it would be very useful to have date and time pickers available. Since Draft 7 of json schema allows for specific formats in the schema, I thought it might be nice to add ability to interpret the format specification for date-time, date and time.
Any suggestions to improve the implementation are highly welcome.