Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Milestone component to backend #102

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Oct 9, 2024

  • modify Milestone component to match MilestoneGroupPublic data
  • refactor /milestone endpoint to use data from backend
  • move lang_id and language from adminStore to langStore
  • fix typo in MilestonePublic model
  • remove static github pages build now that backend is started to be integrated
  • update readme

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0.90909% with 109 lines in your changes missing coverage. Please review.

Project coverage is 15.75%. Comparing base (729220c) to head (314b2b5).

Files with missing lines Patch % Lines
frontend/src/lib/components/Milestone.svelte 0.00% 58 Missing and 1 partial ⚠️
frontend/src/lib/client/schemas.gen.ts 0.00% 27 Missing ⚠️
frontend/src/routes/milestone/+page.svelte 0.00% 9 Missing and 1 partial ⚠️
frontend/src/lib/stores/langStore.ts 0.00% 2 Missing and 1 partial ⚠️
...nd/src/lib/components/Admin/MilestoneGroups.svelte 0.00% 2 Missing ⚠️
...tend/src/lib/components/Admin/UserQuestions.svelte 0.00% 2 Missing ⚠️
...ib/components/Admin/EditMilestoneGroupModal.svelte 0.00% 1 Missing ⚠️
...src/lib/components/Admin/EditMilestoneModal.svelte 0.00% 1 Missing ⚠️
.../lib/components/Admin/EditUserQuestionModal.svelte 0.00% 1 Missing ⚠️
frontend/src/lib/components/Admin/Languages.svelte 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   15.67%   15.75%   +0.08%     
==========================================
  Files          93       94       +1     
  Lines        4562     4538      -24     
  Branches      121      122       +1     
==========================================
  Hits          715      715              
+ Misses       3781     3756      -25     
- Partials       66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- modify Milestone component to match MilestoneGroupPublic data
- refactor /milestone endpoint to use data from backend
- move lang_id and language from adminStore to langStore
- fix typo in MilestonePublic model
- remove static github pages build now that backend is started to be integrated
- update readme
@lkeegan lkeegan force-pushed the connect_milestone_to_backend branch from bb1cfc2 to 314b2b5 Compare October 9, 2024 15:07
Copy link

sonarcloud bot commented Oct 9, 2024

@lkeegan lkeegan merged commit d4ea8f8 into main Oct 9, 2024
5 checks passed
@lkeegan lkeegan deleted the connect_milestone_to_backend branch October 9, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants