Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --clip-negative-radiances flag to ABI L1b reader #637

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 11, 2023

This flag (on by default) removes negative radiances and therefore NaN brightness temperatures. These show up in RGBs that use them, but does not solve what I had hoped it would solve as described in #499. The night_microphysics's use of C07 and the green pixels that show up are inevitable due to how C07 works. Not much we can do about that. This PR does still fix some black pixels in the RGB though.

@djhoese djhoese added the component:reader reading/loading data label Sep 11, 2023
@djhoese djhoese added this to the Geo2Grid 1.2 milestone Sep 11, 2023
@djhoese djhoese self-assigned this Sep 11, 2023
@djhoese
Copy link
Member Author

djhoese commented Sep 11, 2023

Should have mentioned:

Closes #499

@coveralls
Copy link

Coverage Status

coverage: 85.24% (+0.2%) from 85.011% when pulling dda8c87 on djhoese:feature-abi-rad-clip into 21a6ce9 on ssec:main.

@djhoese djhoese merged commit bf8ea3f into ssec:main Sep 11, 2023
9 checks passed
@djhoese djhoese deleted the feature-abi-rad-clip branch September 11, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:reader reading/loading data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants