Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup test warnings #656

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Cleanup test warnings #656

merged 3 commits into from
Nov 28, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 27, 2023

In general it is bad to have warnings go unnoticed/unfailing when running tests. It is a sign that:

  1. Users are seeing warnings
  2. Something is being deprecated and should be dealt with

Some of the warnings currently appearing will be fixed by pytroll/pyspectral#207

@djhoese djhoese self-assigned this Nov 27, 2023
@djhoese djhoese added the code cleanup Refactoring and code complexity cleanup label Nov 27, 2023
@coveralls
Copy link

coveralls commented Nov 27, 2023 •
edited
Loading

Coverage Status

coverage: 85.371% (+0.09%) from 85.282%
when pulling 114266d on djhoese:test-cleanup
into 27a11a5 on ssec:main.

@djhoese djhoese closed this Nov 28, 2023
@djhoese djhoese reopened this Nov 28, 2023
@djhoese djhoese merged commit 82b2599 into ssec:main Nov 28, 2023
11 of 14 checks passed
@djhoese djhoese deleted the test-cleanup branch November 28, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@djhoese djhoese

Labels
code cleanup Refactoring and code complexity cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djhoese @coveralls