Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise dependencies based on TFM #10

Closed
thompson-tomo opened this issue Apr 5, 2024 · 4 comments · Fixed by #11
Closed

Optimise dependencies based on TFM #10

thompson-tomo opened this issue Apr 5, 2024 · 4 comments · Fixed by #11

Comments

@thompson-tomo
Copy link
Contributor

thompson-tomo commented Apr 5, 2024

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like
Atleast 1 if not both the dependencies can be removed as they are provided via the framework.

Describe alternatives you've considered
Accept the additional dependency

Additional context
n/a

@ssg
Copy link
Owner

ssg commented Apr 5, 2024

Which dependency do you mean?

thompson-tomo added a commit to thompson-tomo/HashDepot that referenced this issue Apr 5, 2024
@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Apr 5, 2024

@ssg In the end, it ended up being that both dependencies are able to be provided by the framework see #11

@ssg
Copy link
Owner

ssg commented Apr 17, 2024

Please be more specific. What problem does removing that dependency solve?

@thompson-tomo
Copy link
Contributor Author

it does 2 things, reduce compilation size and reduces chance of CVE's/conflicting versions. Think of those dependencies like System.IO you don't need to add that package if you want access to the file system due to the framework already guranteeing tha the library will be available.

@ssg ssg closed this as completed in #11 Apr 26, 2024
ssg added a commit that referenced this issue Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants