This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
Layout option (3rd times a charm) #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The yielding was not completely obvious to me until I looked at the test since I was used to the way Rails did it (it just magically used the layout). Others will likely have the same issue.
Is only applied if the content type is html
Makes it more in line with the way Rails does this and therefore doesn't supprise people as much. Plus opens the possibility to a mounted Brochure site in Rails can share the same template.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request appends my previous pull request with the new :layout option. Same as before I just put the documentation on a separate pull request so you can pick and choose what you want (if anything). This commit is dependent on the other commit as it appends the documentation as well.