Implement a generic method to mark an element as deprecated. #1425
Conversation
…lement to be marked is scheduler
allevin
added
the
AT: WIP
|
@gvoskuilen if we wanted to get more fancy, we could put in a string in the |
configure.ac
Outdated
| echo "Configuration Information (Make will build the following elements):" | ||
| echo "" | ||
|
|
||
| for e in $dist_element_libraries | ||
| do | ||
| echo "$active_element_libraries" | grep "$e" >/dev/null | ||
| if test $? -eq 0 ; then | ||
| msg="YES" | ||
| if test -e "./src/sst/elements/$e/.depreciated" ; then | ||
| msg="YES - DEPRECIATED" |
There was a problem hiding this comment.
deprecated spelling needs fixing - everywhere including the .deprecated file name
There was a problem hiding this comment.
You know I thought that the spelling looked funny.
|
@allevin I think it's fine as is, if we come across an instance where we decide to leave something deprecated through multiple major releases we could add that. |
|
@gvoskuilen ok, I fixed the spelling, thanks for the catch! 👍 |
allevin
changed the title
allevin
removed
the
AT: WIP
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-elements_withsstcore
Build InformationTest Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-elements_withsstcore
Using Repos:
Pull Request Author: allevin |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SST__AutotestGen2_Devel_Branch_Pull_Request_sst-test_sst-elements_withsstcore
Build InformationTest Name: SST__AutotestGen2_Devel_Branch_Pull_Request_MacOSX_sst-elements_withsstcore
|
|
Status Flag 'Pre-Merge Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 1425: IS A SUCCESS - Pull Request successfully merged |
Implement a generic method to mark an element as deprecated.
This is a similar technique adding the .ignore into the element directory to have it ignored during autogen/configure.
we just add a hidden file called
.deprecatedand the configure script will detect it and mark the the element as YES - DEPRECATED in the configuration summary.The real code changes happen on line 179 (my editor decided to clean up the extra whitespace...)
First element to be marked is scheduler
@gvoskuilen can you review before I release to the autotester?