Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upscaling still runs when the checkbox is cleared if the scale factor is > 1 #106

Closed
ssube opened this issue Feb 6, 2023 · 0 comments
Closed
Assignees
Labels
status/fixed issues that have been fixed and released type/bug broken features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Feb 6, 2023

Setting the scale slider to a value > 1 and then clearing the checkbox does not disable upscaling. The API logic has at least one upscale.scale > 1 check and the enabled flag is not sent.

This broke when I changed the client logic to send the scale/outscale parameters when face correction is enabled. While outscale is needed, the scale parameter is not.

The upscale and correction models eventually need to have separate outscale parameters.

@ssube ssube added status/new issues that have not been confirmed yet type/bug broken features labels Feb 6, 2023
@ssube ssube self-assigned this Feb 6, 2023
@ssube ssube added this to the v0.6 milestone Feb 6, 2023
@ssube ssube mentioned this issue Feb 6, 2023
68 tasks
@ssube ssube added status/fixed issues that have been fixed and released and removed status/new issues that have not been confirmed yet labels Feb 6, 2023
@ssube ssube closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/fixed issues that have been fixed and released type/bug broken features
Projects
None yet
Development

No branches or pull requests

1 participant