Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upscaling with Real ESRGAN v3 produces a neon image #109

Closed
ssube opened this issue Feb 6, 2023 · 1 comment
Closed

upscaling with Real ESRGAN v3 produces a neon image #109

ssube opened this issue Feb 6, 2023 · 1 comment
Labels
status/fixed issues that have been fixed and released type/bug broken features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Feb 6, 2023

Using the Real ESRGAN v3 model exported by the conversion script, I am consistently getting neon green/yellow images with some ghosting, at any scale factor.

image

This may be a problem with the scale factor in the training step, although there is also special behavior for the v3 model in https://github.com/ssube/onnx-web/blob/main/api/onnx_web/chain/upscale_resrgan.py#L53

@ssube ssube mentioned this issue Feb 6, 2023
68 tasks
@ssube ssube added this to the v0.6 milestone Feb 6, 2023
@ssube ssube added status/new issues that have not been confirmed yet type/bug broken features labels Feb 6, 2023
@ssube
Copy link
Owner Author

ssube commented Feb 7, 2023

This was caused by using the RRDB net instead of the SRVGG net. The Real ESRGAN stage will need to have some more logic to switch between those, and I need to write an ONNX wrapper for the SRVGG class if possible (#113).

@ssube ssube closed this as completed Feb 7, 2023
@ssube ssube added status/fixed issues that have been fixed and released and removed status/new issues that have not been confirmed yet labels Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/fixed issues that have been fixed and released type/bug broken features
Projects
None yet
Development

No branches or pull requests

1 participant