Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karras ve scheduler throwing an error #189

Closed
ssube opened this issue Feb 19, 2023 · 1 comment
Closed

karras ve scheduler throwing an error #189

ssube opened this issue Feb 19, 2023 · 1 comment
Labels
scope/api scope/scheduler status/declined issues that have been declined after discussion type/bug broken features

Comments

@ssube
Copy link
Owner

ssube commented Feb 19, 2023

[2023-02-19 16:54:46,835] DEBUG: onnx_web.server.model_cache: cache limit set to 0, not caching model: diffusion                                                                    [2023-02-19 16:54:46,835] DEBUG: onnx_web.server.model_cache: cache limit set to 0, not caching model: scheduler                                                                    
[2023-02-19 16:54:48,207] WARNING: onnx_web.server.device_pool: job txt2img_0_0637df289c9741e6f297abd4f8dc2e33740c22e8c7e0f0fb93c8550e43486387_1676825683.png failed with an error: ['Traceback (most recent call last):
', '  File "/home/ssube/onnx-web/api/onnx_web/server/device_pool.py", line 242, in job_done
    f.result()
', '  File "/usr/lib/python3.10/c
oncurrent/futures/_base.py", line 451, in result
    return self.__get_result()
', '  File "/usr/lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
    raise self._exception
', '  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
', '  File "/home/ssube/onnx-web/
api/onnx_web/diffusion/run.py", line 58, in run_txt2img_pipeline
    result = pipe(
', '  File "/home/ssube/onnx-web/api/onnx_env/lib/python3.10/site-packages/diffusers/pipelines/stable_diffusion/pipeline_onnx_stable_diffusion.py", line 283, in __call__
    scheduler_output = self.scheduler.step(\n', "TypeError: KarrasVeScheduler.step() missing 1 required
 positional argument: 'sample_hat'
"]  
@ssube ssube added status/new issues that have not been confirmed yet type/bug broken features labels Feb 19, 2023
@ssube ssube modified the milestone: v0.8 Feb 19, 2023
@ssube
Copy link
Owner Author

ssube commented Dec 15, 2023

I could wrap this scheduler and provide additional values to the step method, but as of diffusers 0.24.0, the scheduler has been deprecated: https://github.com/huggingface/diffusers/blob/v0.24.0/src/diffusers/schedulers/deprecated/scheduling_karras_ve.py#L164

I'm not going to add new patches to support deprecated schedulers/pipelines unless they offer something that the replacement does not, but I don't think that is the case here.

@ssube ssube closed this as completed Dec 15, 2023
@ssube ssube added status/declined issues that have been declined after discussion and removed status/new issues that have not been confirmed yet labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/api scope/scheduler status/declined issues that have been declined after discussion type/bug broken features
Projects
None yet
Development

No branches or pull requests

1 participant