Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build an EXE bundle for windows #305

Closed
8 of 9 tasks
ssube opened this issue Mar 30, 2023 · 6 comments
Closed
8 of 9 tasks

build an EXE bundle for windows #305

ssube opened this issue Mar 30, 2023 · 6 comments
Labels
status/fixed issues that have been fixed and released type/feature new features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Mar 30, 2023

The setup experience is not the best right now, especially on Windows. There are some tools, like https://pyinstaller.org/en/stable/index.html, that can bundle a Python runtime and modules into a single EXE or folder with an EXE.

@ssube ssube added this to the v0.10 milestone Mar 31, 2023
@ssube ssube added status/progress issues that are in progress and have a branch type/feature new features labels Mar 31, 2023
@ssube
Copy link
Owner Author

ssube commented Mar 31, 2023

This seems to be working, using PyInstaller and https://github.com/ssube/onnx-web/blob/main/exe/win10.directml.dir.spec, and I'm working on uploading the bundle and writing docs.

@ssube ssube added status/fixed issues that have been fixed and released and removed status/progress issues that are in progress and have a branch labels Mar 31, 2023
@ForserX
Copy link
Contributor

ForserX commented Apr 6, 2023

I can offer you the following: to build a startup file on the same C++ with the ability to install dependencies, if there are none, and to run with a commandline.

@ssube
Copy link
Owner Author

ssube commented Apr 6, 2023

What do you have in mind? We should chat. The bundle that I was able to build with PyInstaller runs as a commandline, but it doesn't install any dependencies.

I've been looking through the options that are available for this, https://pypi.org/project/tufup/ looks interesting but has some setup and requires code changes, where as an installer like NSIS or Inno does not require code changes and could help with updates. I would like something that I can run during CI, the npm and pip packages are fully automated, but I don't have a Windows CI box at the moment. I've been considering moving to Github Actions, which could help with that, but requires some other work.

@ForserX
Copy link
Contributor

ForserX commented Apr 6, 2023

Okay. Come on, I'll try to write you a small C++ script over the weekend, which will run at least under FreeBSD. I'll leave with examples of how and what to edit.

@ssube
Copy link
Owner Author

ssube commented Apr 6, 2023

I know some C++, enough to be dangerous, and my only concern with it would be debugging - building and bundling that should not be too hard.

I've been debating if/how to package things for Linux. I am familiar with building apt and rpm packages, but I don't really want to run a repository for those. Windows has too many options.

@ssube ssube added status/progress issues that are in progress and have a branch and removed status/fixed issues that have been fixed and released labels Apr 11, 2023
@ssube
Copy link
Owner Author

ssube commented Apr 16, 2023

I have a v0.10 release candidate bundle, which has a few warnings/errors:

image

@ssube ssube added status/fixed issues that have been fixed and released and removed status/progress issues that are in progress and have a branch labels Apr 30, 2023
@ssube ssube closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/fixed issues that have been fixed and released type/feature new features
Projects
None yet
Development

No branches or pull requests

2 participants