Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

red/green noise in dark areas of some SDXL outputs #438

Closed
ssube opened this issue Dec 17, 2023 · 2 comments
Closed

red/green noise in dark areas of some SDXL outputs #438

ssube opened this issue Dec 17, 2023 · 2 comments
Assignees
@ssube
Labels
pipeline/sdxl scope/api status/fixed issues that have been fixed and released type/bug broken features
Milestone
v0.12

Comments

@ssube
Copy link
Owner

ssube commented Dec 17, 2023 •
edited
Loading

Images generated using some SDXL models show weird pixelated red/green noise, especially in darker areas:

image
image

It doesn't always show up and may show up in some parts of an image but not others. It looks like a rounding error or value going out of bounds and causing the colors to cap out, but I'm not sure where that would be happening.
@ssube ssube added this to the v0.12 milestone Dec 25, 2023
@ssube ssube added status/confirmed issues that have been discussed but not planned type/bug broken features scope/api pipeline/sdxl labels Dec 25, 2023
@ssube ssube self-assigned this Dec 25, 2023
@ssube
Copy link
Owner Author

ssube commented Dec 27, 2023

It sounds like this might be an issue with the v1.0 VAE, based on posts like https://www.reddit.com/r/StableDiffusion/comments/15z07gi/how_to_get_rid_of_sdxl_red_piss/ and https://www.reddit.com/r/StableDiffusion/comments/15ao8v7/sdxl_10_on_comfyui_default_workflow_weird_color/. This might be a good reason to allow dynamic VAE selection.

ssube added a commit that referenced this issue Dec 29, 2023
@ssube
fix(api): turn off SDXL's very visible watermarking (#438)
9736779
@ssube ssube mentioned this issue Dec 30, 2023
Merged
@ssube ssube added status/fixed issues that have been fixed and released and removed status/confirmed issues that have been discussed but not planned labels Dec 30, 2023
@ssube
Copy link
Owner Author

ssube commented Dec 30, 2023

This ended up being a problem with the "invisible" watermark, which is very visible on most images. I'm not sure if this is a bug upstream or side effect of something else, but turning off the watermark fixed it. I may turn the watermark back on eventually, once it is truly invisible.

@ssube ssube mentioned this issue Dec 31, 2023
Closed
40 tasks
@ssube ssube closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssube ssube

Labels
pipeline/sdxl scope/api status/fixed issues that have been fixed and released type/bug broken features
Projects
None yet
Milestone
v0.12
Development

No branches or pull requests
1 participant
@ssube