Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy buttons do not always set the source correctly #64

Closed
ssube opened this issue Jan 19, 2023 · 2 comments
Closed

copy buttons do not always set the source correctly #64

ssube opened this issue Jan 19, 2023 · 2 comments
Assignees
Labels
status/fixed issues that have been fixed and released type/bug broken features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Jan 19, 2023

The copy to img2img and copy to inpaint buttons do not always set the source property correctly, so clicking that button and then clicking Generate without adjusting any parameters will not send a request, no loading card appears, and nothing actually happens. The console errors indicate that the source property is usually empty at that point.

@ssube ssube added status/new issues that have not been confirmed yet type/bug broken features labels Jan 19, 2023
@ssube ssube added this to the v0.5 milestone Jan 19, 2023
@ssube
Copy link
Owner Author

ssube commented Jan 20, 2023

This seems to be a problem with the inpainting mask, in particular. I have not been able to reproduce it recently with img2img mode, but copying an inpaint source and then sending the request without editing the mask at all will break things.

@ssube
Copy link
Owner Author

ssube commented Jan 21, 2023

Copying a new source image to the inpaint tab now clears the mask and marks the canvas as dirty, so the newly-clear mask is saved to state, and the button works immediately without any painting or adjusting of the settings.

@ssube ssube closed this as completed Jan 21, 2023
@ssube ssube added status/fixed issues that have been fixed and released and removed status/new issues that have not been confirmed yet labels Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/fixed issues that have been fixed and released type/bug broken features
Projects
None yet
Development

No branches or pull requests

1 participant