Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache and convert CodeFormer model #95

Closed
ssube opened this issue Feb 5, 2023 · 1 comment
Closed

cache and convert CodeFormer model #95

ssube opened this issue Feb 5, 2023 · 1 comment
Labels
status/fixed issues that have been fixed and released type/bug broken features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Feb 5, 2023

The CodeFormer library automatically downloads the model checkpoint from Github or Wasabi. The app should run well on a read-only filesystem with no outgoing network access (except S3), so that model needs to be downloaded and converted ahead of time.

@ssube ssube added status/new issues that have not been confirmed yet type/bug broken features labels Feb 5, 2023
@ssube ssube modified the milestones: v0.7, v0.6 Feb 5, 2023
@ssube
Copy link
Owner Author

ssube commented Feb 5, 2023

The CodeFormer model has been added to the conversion script using the same code as GFPGAN (which causes some confusing log messages). That seems to work and does export an ONNX model, which is enough for the correction model menu, but the actual code is still using the CPU device/path and still downloads a checkpoint.

@ssube ssube added status/progress issues that are in progress and have a branch status/fixed issues that have been fixed and released and removed status/new issues that have not been confirmed yet status/progress issues that are in progress and have a branch labels Feb 6, 2023
@ssube ssube closed this as completed Feb 12, 2023
@ssube ssube mentioned this issue Feb 14, 2023
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/fixed issues that have been fixed and released type/bug broken features
Projects
None yet
Development

No branches or pull requests

1 participant