Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix several issues #1053

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix several issues #1053

wants to merge 6 commits into from

Conversation

qiaogaojian
Copy link

  • feat: add new shortcut for 87-key keybord
  • fix: sometime this.reviewQueueView is undifine, add a validation to prevent exception.
  • fix: code block parse issue
  • fix: save note trim blank line will split a card to several part

@ronzulu
Copy link
Collaborator

ronzulu commented Aug 23, 2024

Hey there, typically (on this project) each PR is only about a single issue, or perhaps a group of related issues. I'm not sure if we would be able to merge your PR as the different fixes aren't related.

feat: add new shortcut for 87-key keybord

Is this just your personal preference? Please note that there is a request for a generic feature at Custom keyboard shortcuts to answer reviews #336 .

fix: sometime this.reviewQueueView is undifine, add a validation to prevent exception.

Interesting, I've never seen this myself. Do you know under what circumstances this occurs?

fix: code block parse issue

Sorry, but the parser has been completely reworked as part of Added new option allowing for multiline cards with empty lines #1012 . Best to wait for that to be merged into the master branch, and see if it is still an issue then.

fix: save note trim blank line will split a card to several part

Could you please explain this better – I don't know what this means. Also, there have been significant code changes as per refactor code to support diff methods of storing the scheduling info, and diff SR algorithms. Best to wait for that to be merged into the master branch, and see if it is still an issue then.

Thanks
Ronny

@st3v3nmw
Copy link
Owner

st3v3nmw commented Sep 22, 2024

Hi @qiaogaojian, the two PRs mentioned above have since been merged.. The parser and other parts of the codebase have been reworked. Please confirm if the issues you raised are still occurring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants