Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for many clozures within a single flashcard #733

Closed
wants to merge 0 commits into from

Conversation

Stefanuk12
Copy link

@Stefanuk12 Stefanuk12 commented Aug 25, 2023

Overview

Currently, a flashcard can only have one cloze and the rest are treated as highlights. This PR hides and treats all possible clozures. The new system is also simpler and allows more characters to be easily added or removed in the future.

Note: I accidentally created a new branch from my previous PR which results in the weird commit history. View the files changed for a better overview...

Changed behaviour

Before

creates two flashcards

many text
such surprise [...] more ==text==
some text after
many text
such surprise ==wow== more [...]
some text after

After

many text
such surprise [...] more [...]
some text after

Addresses

#486

Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution 😄!

Sorry the underlying code has gone through a major refactor recently. I'm not sure if you're still available to help resolve the merge conflicts.

Stephen,

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pnpm instead

@Stefanuk12
Copy link
Author

Yeah, I'm currently working on implementing an Anki card parser which could be an alternative to this PR. However, a global switch (like implemented within this PR) isn't ideal, so I might not merge unless someone can think of a more intuitive solution.

@Stefanuk12
Copy link
Author

Going to work on re-creating this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants