Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug #670 apply label customisation easy/good/hard uniformly across buttons & menu #835

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

ronzulu
Copy link
Collaborator

@ronzulu ronzulu commented Jan 12, 2024

This fixes bug:
#670

Minor issues for some non-English languages

For some languages, the translation for the difficulty levels is slightly different depending on context, e.g. for Easy in Russian:

REVIEW_EASY_FILE_MENU: "Повторение: Легко",
REVIEW_NOTE_EASY_CMD: "Повторять заметку как Лёгкую",

i.e. Легко verses Лёгкую

I'm assuming that any grammatical error introduced by using a single term for Easy etc is minor, and would still be understood by users. Also, I assume that the translation of "Review note as" could be modified in affected languages to make this update grammatically correct.

REVIEW_DIFFICULTY_FILE_MENU: "Review: ${difficulty}",
REVIEW_NOTE_DIFFICULTY_CMD: "Review note as ${difficulty}",

Screenshots

Previously implemented:
image

Now also:
image

image

image

Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@st3v3nmw st3v3nmw merged commit e41a9f5 into st3v3nmw:master Jan 15, 2024
1 check passed
@ronzulu ronzulu deleted the bug-670-label-customisation branch April 25, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants