Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keep_parent parameter to add_child and add_item #1116 #1117

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented May 11, 2023

Related Issue(s):

Description:

Adds a keep_parent parameter to add_child and add_item to allow keeping the current parent if one is set. This makes the add calls more predictable while keeping backward compatibility.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@m-mohr m-mohr marked this pull request as ready for review May 11, 2023 18:20
@gadomski gadomski linked an issue May 11, 2023 that may be closed by this pull request
@gadomski gadomski added this to the 1.8 milestone May 11, 2023
@gadomski gadomski added this pull request to the merge queue May 11, 2023
Merged via the queue into main with commit f10a7de May 11, 2023
@gadomski gadomski deleted the keep_parent branch May 11, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arbitrary saving location of child catalogs
2 participants